Codecov Report

Merging #8209 (1f88d68) into master (8042408) will decrease coverage by 6.64%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #8209      +/-   ##
============================================
- Coverage     70.97%   64.32%   -6.65%     
  Complexity     4313     4313              
============================================
  Files          1626     1581      -45     
  Lines         84851    83048    -1803     
  Branches      12790    12579     -211     
============================================
- Hits          60221    53424    -6797     
- Misses        20496    25788    +5292     
+ Partials       4134     3836     -298     

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8042408...1f88d68. Read the comment docs.

done. but I think we should move it over anyway.
originally the idea was to save startup tear down time using stateful suite. but since we already have "stateless" version of the PinotHelixResourceManagerTest, there's no reason we need the stateful one because we anyway will start a new cluster

The logic in the stateless test is slightly different, where it actually tests the tenant behavior with fake brokers and servers which doesn't apply to the segment upload where real server might be required (even thought it might not be tested). I'd suggest keeping the test unmoved to limit the change and see if changing timeout fixes the issue.

The logic in the stateless test is slightly different, where it actually tests the tenant behavior with fake brokers and servers which doesn't apply to the segment upload where real server might be required (even thought it might not be tested). I'd suggest keeping the test unmoved to limit the change and see if changing timeout fixes the issue.

sounds good.
although i still think the test should be stateless, for one it is not suppose to test against server/broker logic in pinot-controller module which it does in the stateful test class; also it worked perfectly in stateless test.
however given we don't have a test to cover the lineage logic in broker/server separately. i would agree to keep the current behavior (though it is much slower)